-
Notifications
You must be signed in to change notification settings - Fork 16
New landing page design #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Preview the changes: https://turinglang.org/pr-previews/119 |
If anyone is interested, then please feel free to take on this PR! |
* very basic redesign * make buttons interactive
* add dangling code example * add code example section
* quickfix alignment * add news and clean up scss
* improve colors * better link hover color
* paste in svg * responsive svg header
using the same background colour for the team "cards" as for the non-hoverable cards on the landing page
- added links to discourse and slack to the buttons at the top of the page - moved link to libraries page to "Learn more" section
Co-authored-by: Penelope Yong <[email protected]>
0046a57
to
e9e14d5
Compare
I will definitely have time to finish this in July. Which points would you like to see addressed before this PR can be merged? |
Revisiting this. Is there a reason why the old PR was closed? Also, I'd personally be happy to merge if some of the placeholder content is removed. Honestly, it's not like the existing front page has any resources, so even a fairly clean slate would be a huge improvement over the current one. |
No animation, just simple branding header, I used new logo now and its looking good!
Thank You!
I added some consistent styles for border and hover effect, lets keep it for now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really neat, good work @shravanngoswamii!
Only thing I would change is that in the News section, I'm not sure how the items that are displayed are picked, but currently it shows e.g. a post from 2019 announcing our blog. Maybe it could instead just show the three newest ones?
We just have to put |
Great work @shravanngoswamii ! What do you think about changing the The aligned version is more appealing to my eyes, but once again this is of course subjective to some degree. With ![]() With ![]() |
All thanks to you @simonsteiger!
I did think of that first, but using
We can try something else, but I thought having bit space make the content look nested under titles so I kept it! |
Ouch! I didn't think of that, hmm. The current solution is definitely better then. Maybe there's a way to shrink the card width and force one row until it collapses into the mobile layout with a single column? I'd be happy to tinker with this a bit in the next days; if it doesn't work, we can simply stick with your current solution. :) |
Feel free to experiment and push directly to this branch—I’ve added you as a collaborator! One more favor @simonsteiger, if you have some time: Could you modularize the styles.css and convert all the styles to SCSS, like you did in your original PR? That approach was more optimized than what I’m using now, and I’m not much familiar with SCSS or design principles myself. here is the your modularized theming code from that old PR for reference, incase you try: theming.zip |
Oh, I'd be happy to help, yes! I should be able to find the time for this. :) |
Continuing #105
Preview the changes: https://turinglang.org/pr-previews/119